Re: [PR] fix: Broken splitter in sql lab and some minor visual fixes [superset]

Sat, 18 Oct 2025 17:52:13 -0700 


korbit-ai[bot] commented on code in PR #35416:
URL: https://github.com/apache/superset/pull/35416#discussion_r2393992908


##########
superset-frontend/src/explore/components/ExploreAlert.tsx:
##########
@@ -55,14 +62,16 @@ export const ExploreAlert = forwardRef(
       showIcon
     >
       {primaryButtonText && primaryButtonAction && (
-        <div>
+        <ButtonContainer>
           {secondaryButtonAction && secondaryButtonText && (
-            <Button onClick={secondaryButtonAction}>
+            <Button buttonStyle="secondary" onClick={secondaryButtonAction}>
               {secondaryButtonText}
             </Button>
           )}
-          <Button onClick={primaryButtonAction}>{primaryButtonText}</Button>
-        </div>
+          <Button buttonStyle="secondary" onClick={primaryButtonAction}>
+            {primaryButtonText}
+          </Button>

Review Comment:
   ### Primary button has secondary styling <sub>![category 
Design](https://img.shields.io/badge/Design-0d9488)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   The primary button is styled as 'secondary' which contradicts its semantic 
role as the primary action button.
   
   
   ###### Why this matters
   Users will be confused about which action is primary since both buttons have 
the same visual styling, potentially leading to incorrect user interactions and 
poor UX.
   
   ###### Suggested change ∙ *Feature Preview*
   Change the primary button's buttonStyle to 'primary' to match its semantic 
role:
   
   ```tsx
   <Button buttonStyle="primary" onClick={primaryButtonAction}>
     {primaryButtonText}
   </Button>
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/e289d3c0-c820-4a6f-bdfb-8bdd88d71d38/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/e289d3c0-c820-4a6f-bdfb-8bdd88d71d38?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/e289d3c0-c820-4a6f-bdfb-8bdd88d71d38?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/e289d3c0-c820-4a6f-bdfb-8bdd88d71d38?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/e289d3c0-c820-4a6f-bdfb-8bdd88d71d38)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:00c8bca3-e214-40bb-a669-195d13e33448 -->
   
   
   [](00c8bca3-e214-40bb-a669-195d13e33448)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to