innovark37 opened a new pull request, #35751:
URL: https://github.com/apache/superset/pull/35751

   ### SUMMARY
   Strings `Select all` and `Deselect all` are not extracted from `Select` 
component when following the 
[documentation](https://superset.apache.org/docs/contributing/howtos/#extracting-new-strings-for-translation).
 This PR fixes missing translations for Select component. 
   FYI: `Deselect all` is translated only because `ListView` component uses 
this string.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   **BEFORE**
   <img width="254" height="441" alt="image" 
src="https://github.com/user-attachments/assets/6acae06d-6967-4f7b-a20a-59dbb378345c";
 />
   **AFTER**
   <img width="246" height="465" alt="image" 
src="https://github.com/user-attachments/assets/0d620412-7a81-4484-8c93-f078fbaf3ed5";
 />
   
   
   ### TESTING INSTRUCTIONS
   1. Add next lines to config file:
   ```
   BABEL_DEFAULT_LOCALE` = "ru"
   LANGUAGES = {
     "ru": {"flag": "ru", "name": "Русский"},
     "en": {"flag": "us", "name": "English"}
   }
   ```
   2. Start the application.
   3. Create dashboard.
   4. Add native filter (Filter type = "Value").
   5. Verify the translations in Select footer (strings `Select all` and 
`Deselect all`).
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to