dpgaspar commented on code in PR #35454:
URL: https://github.com/apache/superset/pull/35454#discussion_r2449280982


##########
superset/security/guest_token.py:
##########
@@ -59,6 +59,7 @@ class GuestUser(AnonymousUserMixin):
     """
 
     is_guest_user = True
+    active = True

Review Comment:
   yeah the error is:
   ```
   if current_user.is_authenticated and current_user.active:
   ```
   
   so it should be like this, but can you add the is_active also like:
   ``` python
       @property
       def is_active(self):
           return self.active
   ```
   
   Looking at it, it does seem that FAB should be using `is_active` instead of 
`active`, I'll make the change.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to