bito-code-review[bot] commented on PR #35798:
URL: https://github.com/apache/superset/pull/35798#issuecomment-3432731641
<details open>
<summary><strong>Interaction Diagram by <a
href="https://bito.ai#sequence_diagram";>Bito</a></strong></summary>
```mermaid
sequenceDiagram
participant API as ChartRestApi<br/>🔄 Updated | ●●● High
participant POST as ChartPostSchema<br/>🔄 Updated | ●●● High
participant PUT as ChartPutSchema<br/>🔄 Updated | ●●● High
participant UTIL as validate_query_context_metadata<br/>🟩 Added | ●●● High
participant JSON as JSON Parser
participant CMD as CreateChartCommand
participant DB as Database
Note over POST, PUT: Enhanced validation for<br/>query_context metadata
API->>POST: POST /api/v1/chart (create)
POST->>UTIL: Validate query_context field
UTIL->>JSON: Parse and validate JSON
JSON-->>UTIL: Return parsed data
UTIL-->>POST: Validation result
POST->>CMD: Execute chart creation
CMD->>DB: Store validated chart
API->>PUT: PUT /api/v1/chart/{id} (update)
PUT->>UTIL: Validate query_context field
UTIL-->>PUT: Validation result
```
Critical path:
ChartRestApi->ChartPostSchema->validate_query_context_metadata->JSON
Parser->CreateChartCommand->Database
> **Note:** The chart creation and update flows now enforce stricter
validation on query_context fields, requiring 'datasource' and
'queries' metadata. This ensures chart data retrieval has necessary
context information before persistence.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
