bito-code-review[bot] commented on PR #35801:
URL: https://github.com/apache/superset/pull/35801#issuecomment-3433399829
<details open>
<summary><strong>Interaction Diagram by <a
href="https://bito.ai#sequence_diagram";>Bito</a></strong></summary>
```mermaid
sequenceDiagram
participant User as User Interface
participant FilterCtrl as AdhocFilterControl<br/>🔄 Updated | ●●○ Medium
participant Popover as AdhocFilterEditPopover
participant SimpleTab as AdhocFilterEditPopoverSimpleTabContent<br/>🔄
Updated | ●●● High
participant Hook as useAdvancedDataTypes<br/>🔄 Updated | ●●○ Medium
participant API as SupersetClient API
participant Input as Input Component<br/>🔄 Updated | ●●○ Medium
Note over SimpleTab: Focus management & test restructuring<br/>improved
input handling
User->>FilterCtrl: Create/Edit Filter
FilterCtrl->>Popover: Open filter editor
Popover->>SimpleTab: Render simple tab content
SimpleTab->>Hook: Initialize advanced data types
Hook->>API: Fetch advanced data type info
API-->>Hook: Return data type metadata
SimpleTab->>Input: Focus comparator input (new ref logic)
Input-->>SimpleTab: Handle user input changes
SimpleTab-->>Popover: Update filter state
Popover-->>FilterCtrl: Apply filter changes
```
Critical path: User
Interface->AdhocFilterControl->AdhocFilterEditPopover->AdhocFilterEditPopoverSimpleTabContent->Input
Component
> **Note:** The changes improve focus management in filter input fields
using useRef and useEffect, restructure tests from nested describe blocks to
top-level tests, and optimize the useAdvancedDataTypes hook with useCallback.
The modifications enhance user experience by ensuring proper input focus
behavior while maintaining backward compatibility with existing filter
functionality.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
