xe-nvdk commented on PR #35805: URL: https://github.com/apache/superset/pull/35805#issuecomment-3433813257
> Hi @xe-nvdk! This has two top level headers but I think a single one for: > > #### Arc > Would be better. Then have the two methods within there. "There are two ways to connect Superset to Arc: > > 1. (Recommended) `arc-superset-arrow` extracts data via Apache Arrow. This method is 3-5x faster than transmitting the data as JSON. [ ...connection details... ] > 2. `arc-superset-json` transmits the data as JSON. [... why you would ever use this instead of Arrow ...] [... connection details ...] > > Is that clear and what do you think? I feel like that would be clearer. Please change anything I got wrong. > > Besides reorganizing the content, the one piece that feels missing is why anyone would use the JSON option if Arrow is much faster. Hey Sam, hope you are doing well. We decided to keep JSON, cause in small datasets or queries is faster than arrow, arrow benefits are noted in large datasets, 10000 rows or more. That is the reason that for now we are keeping both in our API / System and did two separates plugins for Superset. Agree with you on using one header for two. Let me push the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
