bito-code-review[bot] commented on PR #35806:
URL: https://github.com/apache/superset/pull/35806#issuecomment-3434257555
<details open>
<summary><strong>Interaction Diagram by <a
href="https://bito.ai#sequence_diagram";>Bito</a></strong></summary>
```mermaid
sequenceDiagram
participant REP as Report Execute Command
participant SCR as Screenshot Service<br/>🔄 Updated | ●●○ Medium
participant WEB as WebDriver Playwright
participant TSS as take_tiled_screenshot<br/>🔄 Updated | ●●● High
participant PAGE as Playwright Page
participant CMB as combine_screenshot_tiles
Note over TSS: Enhanced viewport bounds<br/>validation & clipping logic
REP->>SCR: get_screenshot(user)
SCR->>WEB: get_screenshot(url, element, user)
WEB->>TSS: take_tiled_screenshot(page, element_name)
TSS->>PAGE: evaluate() - get viewport info
PAGE-->>TSS: viewport dimensions & element bounds
TSS->>PAGE: screenshot(clip) - with validated bounds
PAGE-->>TSS: tile screenshot bytes
TSS->>CMB: combine_screenshot_tiles(tiles)
CMB-->>TSS: combined screenshot
TSS-->>WEB: screenshot bytes
WEB-->>SCR: screenshot data
SCR-->>REP: final screenshot
```
Critical path: Report Execute Command->Screenshot Service->WebDriver
Playwright->take_tiled_screenshot->combine_screenshot_tiles
> **Note:** The take_tiled_screenshot function now includes robust viewport
bounds validation and clipping logic to handle edge cases like negative element
positions and elements extending beyond viewport boundaries. This prevents
invalid clip dimensions and improves screenshot reliability for large
dashboards.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
