bito-code-review[bot] commented on PR #35810:
URL: https://github.com/apache/superset/pull/35810#issuecomment-3434651315
<details open>
<summary><strong>Interaction Diagram by <a
href="https://bito.ai#sequence_diagram";>Bito</a></strong></summary>
```mermaid
sequenceDiagram
participant USER as User Interface
participant MODAL as DatasourceModal
participant EDITOR as DatasourceEditor<br/>🔄 Updated | ●●● High
participant USAGE as DatasetUsageTab<br/>🔄 Updated | ●●○ Medium
participant API as SupersetClient API
participant TOAST as Toast System
Note over EDITOR, USAGE: Mount tracking prevents<br/>state updates on
unmounted components
USER->>MODAL: Open dataset editor
MODAL->>EDITOR: Initialize component
EDITOR->>EDITOR: Set isComponentMounted = true
EDITOR->>USAGE: Render usage tab
USAGE->>USAGE: Set isMountedRef = true
USAGE->>API: Fetch chart usage data
API-->>USAGE: Return chart data
USAGE->>TOAST: Show success/error messages
USER->>MODAL: Close editor
EDITOR->>EDITOR: Set isComponentMounted = false
USAGE->>USAGE: Set isMountedRef = false
```
Critical path: User
Interface->DatasourceModal->DatasourceEditor->DatasetUsageTab->SupersetClient
API->Toast System
> **Note:** The changes add mount tracking to DatasourceEditor and
DatasetUsageTab components to prevent state updates after unmounting. This
prevents React warnings and potential memory leaks when async operations
complete after component cleanup.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
