sadpandajoe commented on PR #35809: URL: https://github.com/apache/superset/pull/35809#issuecomment-3438291398
> Looks good to me! The only possible change I see is deleting `generate_table()` if it's no longer used? Right now you've added a note that it's deprecated, then kept it. > > Though I see you made a tweak to keep it compatible with the other new changes so if you want to keep it for that sake, no problem. Maybe we remove it in six months during cleanup. Yeah I kept it in there for backwards compatibility just in case. We can remove it later I think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
