ngokturkkarli commented on code in PR #35317:
URL: https://github.com/apache/superset/pull/35317#discussion_r2456985783
##########
superset-frontend/cypress-base/cypress/e2e/dashboard/nativeFilters.test.ts:
##########
@@ -160,6 +160,57 @@ describe('Native filters', () => {
);
});
+ it('user cannot create bi-directional dependencies between filters', () =>
{
+ prepareDashboardFilters([
+ { name: 'region', column: 'region', datasetId: 2 },
+ { name: 'country_name', column: 'country_name', datasetId: 2 },
+ { name: 'country_code', column: 'country_code', datasetId: 2 },
+ { name: 'year', column: 'year', datasetId: 2 },
+ ]);
+ enterNativeFilterEditModal();
+
+ // First, make country_name dependent on region
+ selectFilter(1);
+
cy.get(nativeFilters.filterConfigurationSections.displayedSection).within(
+ () => {
+ cy.contains('Values are dependent on other filters')
+ .should('be.visible')
+ .click();
+ },
+ );
+ addParentFilterWithValue(0, testItems.topTenChart.filterColumnRegion);
+
+ // Second, make country_code dependent on country_name
+ selectFilter(2);
+
cy.get(nativeFilters.filterConfigurationSections.displayedSection).within(
+ () => {
+ cy.contains('Values are dependent on other filters')
+ .should('be.visible')
+ .click();
+ },
+ );
+ addParentFilterWithValue(0, testItems.topTenChart.filterColumn);
+
+ // Now select region filter and try to add dependency
+ selectFilter(0);
+
cy.get(nativeFilters.filterConfigurationSections.displayedSection).within(
+ () => {
+ cy.contains('Values are dependent on other filters')
+ .should('be.visible')
+ .click();
+
+ // Verify that only 'year' is available as dependency for region
+ // 'country_name' and 'country_code' should not be available (would
create circular dependency)
+ cy.get('input[aria-label^="Limit type"]').click({ force: true });
+ cy.get('.ant-select-dropdown').should('be.visible');
+ cy.get('.ant-select-dropdown').should('contain', 'year');
+ cy.get('.ant-select-dropdown').should('not.contain', 'country_name');
+ cy.get('.ant-select-dropdown').should('not.contain', 'country_code');
+ cy.get('.ant-select-dropdown').contains('year').click();
Review Comment:
Sure, we can use it. It is fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
