bito-code-review[bot] commented on PR #35821:
URL: https://github.com/apache/superset/pull/35821#issuecomment-3439373011
<details open>
<summary><strong>Interaction Diagram by <a
href="https://bito.ai#sequence_diagram";>Bito</a></strong></summary>
```mermaid
sequenceDiagram
participant Dashboard as Dashboard Component
participant MarkdownComp as MarkdownConnected<br/>🔄 Updated | ●●○ Medium
participant SafeMD as SafeMarkdown
participant GlobalStyles as GlobalStyles.tsx<br/>🔄 Updated | ●●○ Medium
participant Theme as Theme.tsx
participant AllowedTokens as allowedAntdTokens<br/>🟩 Added | ●●● High
participant TestFile as Markdown.test.tsx<br/>🟩 Added | ●●● High
Note over AllowedTokens: fontWeightStrong added to<br/>allowed Ant Design
tokens list
Dashboard->>MarkdownComp: Render with markdown content
MarkdownComp->>SafeMD: Render markdown with **bold**
SafeMD-->>MarkdownComp: Return HTML with <strong> tags
Theme->>AllowedTokens: Filter tokens via allowedAntdTokens
AllowedTokens-->>Theme: Include fontWeightStrong token
Theme-->>GlobalStyles: Provide theme with fontWeightStrong
GlobalStyles->>GlobalStyles: Apply font-weight to <strong> tags
TestFile->>Theme: Verify fontWeightStrong exists & > 400
Theme-->>TestFile: Confirm token available
```
Critical path:
Dashboard->MarkdownConnected->SafeMarkdown->GlobalStyles->allowedAntdTokens
(MODIFIED)
> **Note:** The diff adds 'fontWeightStrong' to allowedAntdTokens
and converts Markdown tests from JSX to TypeScript. This ensures bold markdown
rendering works by providing the required font-weight token to GlobalStyles,
which applies it to <strong> tags and headings.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
