Re: [PR] feat(docs): add documentation for usage of minio or other s3 compatible service as a cache backend or celery results backend [superset]

Fri, 24 Oct 2025 00:18:11 -0700 


korbit-ai[bot] commented on code in PR #35825:
URL: https://github.com/apache/superset/pull/35825#discussion_r2459121215


##########
docs/docs/configuration/cache.mdx:
##########
@@ -34,13 +33,29 @@ FILTER_STATE_CACHE_CONFIG = {
 }
 ```
 
+To configure the filter state cache using MinIO or other S3 compatible service:
+
+```python
+FILTER_STATE_CACHE_CONFIG = {
+    'CACHE_TYPE': 'minio_cache.MinioCacheBackend'
+    'CACHE_MINIO_ENDPOINT': 'localhost:9000'
+    'CACHE_MINIO_ACCESS_KEY': 'minioadmin'
+    'CACHE_MINIO_SECRET_KEY': 'minioadmin'
+    'CACHE_MINIO_BUCKET': 'superset'
+    'CACHE_MINIO_SECURE': False  # Set to True for HTTPS,
+    'CACHE_DEFAULT_TIMEOUT': 300

Review Comment:
   ### Suboptimal cache timeout for MinIO backend <sub>![category 
Performance](https://img.shields.io/badge/Performance-4f46e5)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   The MinIO cache timeout is set to 300 seconds (5 minutes) which is 
significantly lower than the Redis example's 86400 seconds (24 hours).
   
   
   ###### Why this matters
   This short timeout will cause frequent cache misses and increased I/O 
operations to MinIO, leading to higher latency and reduced performance compared 
to other cache backends. Users following this example may experience degraded 
application performance.
   
   ###### Suggested change ∙ *Feature Preview*
   Increase the cache timeout to match other backends for consistency and 
better performance:
   
   ```python
   'CACHE_DEFAULT_TIMEOUT': 86400  # 24 hours, consistent with Redis example
   ```
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/b8fce156-8651-4ee8-8234-47cdb0df21f6/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/b8fce156-8651-4ee8-8234-47cdb0df21f6?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/b8fce156-8651-4ee8-8234-47cdb0df21f6?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/b8fce156-8651-4ee8-8234-47cdb0df21f6?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/b8fce156-8651-4ee8-8234-47cdb0df21f6)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:8685e660-76a4-4085-a98b-55e666282b95 -->
   
   
   [](8685e660-76a4-4085-a98b-55e666282b95)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to