oleksandrshalbanov-dev opened a new issue, #35830:
URL: https://github.com/apache/superset/issues/35830

   ## Description
   Didn't find an appropriate category for this issue, so posting here.
   Working with the Superset helm chart, I've figured out that manifests do not 
follow best practices described here: 
   
https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/
   
   Currently, I can see the following labels:
      labels:                                                                   
                                                                              
        app: superset
        release: superset                                                       
                                                                                
                                                                                
                           
        app.kubernetes.io/managed-by: Helm
        chart: superset-0.15.0
        heritage: Helm
   
   And here are selectors:
      selector:
        matchLabels:
          app: superset
          release: superset
   
   I'd prefer to see here at leas the following labels and appropriate selector 
for deployments, services, etc:
      labels:
        app.kubernetes.io/instance: superset
        app.kubernetes.io/name: superset
   
   
   
   ## Design input
   [describe any input/collaboration you'd like from designers, and
   tag accordingly. For design review, add the
   label `design:review`. If this includes a design proposal,
   include the label `design:suggest`]
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to