Re: [PR] fix(dashboard): prevent tab content cutoff and excessive whitespace in empty tabs [superset]

Fri, 24 Oct 2025 14:34:10 -0700 


korbit-ai[bot] commented on code in PR #35834:
URL: https://github.com/apache/superset/pull/35834#discussion_r2462040596


##########
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx:
##########
@@ -305,7 +305,7 @@ const StyledDashboardContent = styled.div<{
 
       /* this is the ParentSize wrapper */
     & > div:first-child {
-        height: inherit !important;
+        height: 100% !important;

Review Comment:
   ### ParentSize height reference may break chart rendering <sub>![category 
Functionality](https://img.shields.io/badge/Functionality-0284c7)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   Changing from 'inherit' to '100%' for the ParentSize wrapper height may 
break responsive chart sizing when the parent container doesn't have an 
explicit height set.
   
   
   ###### Why this matters
   The ParentSize component from @visx/responsive relies on inheriting 
dimensions from its parent. Using '100%' instead of 'inherit' assumes the 
parent has a defined height, but if the parent's height is 'auto' or undefined, 
the child will have no reference point and may collapse to 0 height or cause 
layout issues.
   
   ###### Suggested change ∙ *Feature Preview*
   Verify that all parent containers of the ParentSize wrapper have explicit 
height values set, or consider using a more robust approach like:
   
   ```css
   & > div:first-child {
     height: inherit !important;
     min-height: 100%;
   }
   ```
   
   This maintains the inherit behavior while ensuring a minimum height fallback.
   
   
   ###### Provide feedback to improve future suggestions
   [![Nice 
Catch](https://img.shields.io/badge/👍%20Nice%20Catch-71BC78)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/990c77fc-bc69-4b07-bcd7-963cf34bcfba/upvote)
 
[![Incorrect](https://img.shields.io/badge/👎%20Incorrect-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/990c77fc-bc69-4b07-bcd7-963cf34bcfba?what_not_true=true)
  [![Not in 
Scope](https://img.shields.io/badge/👎%20Out%20of%20PR%20scope-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/990c77fc-bc69-4b07-bcd7-963cf34bcfba?what_out_of_scope=true)
 [![Not in coding 
standard](https://img.shields.io/badge/👎%20Not%20in%20our%20standards-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/990c77fc-bc69-4b07-bcd7-963cf34bcfba?what_not_in_standard=true)
 
[![Other](https://img.shields.io/badge/👎%20Other-white)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/990c77fc-bc69-4b07-bcd7-963cf34bcfba)
   </details>
   
   <sub>
   
   💬 Looking for more details? Reply to this comment to chat with Korbit.
   </sub>
   
   <!--- korbi internal id:f384cbe3-54c9-4c01-8805-6c0dc52bbd9b -->
   
   
   [](f384cbe3-54c9-4c01-8805-6c0dc52bbd9b)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to