aminghadersohi opened a new pull request, #35840: URL: https://github.com/apache/superset/pull/35840
Restore essential behavioral documentation removed in 241cfa52037. LLMs need this info to use tools correctly (e.g., charts saved by default). Changes: - generate_chart: Restored save_chart=True default behavior, LLM display guidance - update_chart: Clarified requires saved chart, display URL guidance - generate_dashboard: Noted chart access requirements and 2-column layout - get_chart_info: Added LLM display URL guidance - get_chart_data: Clarified purpose for LLM analysis without image rendering - generate_explore_link: Restored PREFERRED tool guidance vs generate_chart - update_chart_preview: Clarified cached preview workflow and display guidance Token reduction: ~70% vs original verbose docs while preserving critical info. This restores LLM-critical behavioral guidance while maintaining token efficiency. <!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
