bito-code-review[bot] commented on PR #35890:
URL: https://github.com/apache/superset/pull/35890#issuecomment-3461989908
<details open>
<summary><strong>Interaction Diagram by <a
href="https://bito.ai#sequence_diagram";>Bito</a></strong></summary>
```mermaid
sequenceDiagram
participant User as User Request
participant API as REST API<br/>
participant Explore as ExploreMixin.get_sqla_query<br/>🔄 Updated | ●●○ Medium
participant TP as TemplateProcessor
participant Filter as Filter Logic<br/>🔄 Updated | ●●○ Medium
participant DB as Database
User->>API: Query with time filter
API->>Explore: get_sqla_query(query_obj)
Explore->>TP: Process Jinja template
TP-->>Explore: Returns removed_filters list
Explore->>Filter: Check filter_col_name & __timestamp
Note over Filter: If flt_col == __timestamp, check both<br/>alias and actual
column name
Filter-->>Explore: should_skip_filter decision
Explore->>DB: Build WHERE clause (skip if in removed_filters)
DB-->>API: Return compiled SQL
API-->>User: Response
```
Critical path: User Request -> REST API -> ExploreMixin.get_sqla_query
-> Filter Logic -> Database
> **Note:** The fix enhances filter-skipping logic to handle the __timestamp
alias correctly. When a Jinja template uses
get_time_filter(remove_filter=True), the filter is marked for removal. The
updated code now checks both the alias and the actual column name to prevent
double-application of time filters in virtual datasets.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
