korbit-ai[bot] commented on code in PR #35897:
URL: https://github.com/apache/superset/pull/35897#discussion_r2475695098
##########
superset-frontend/plugins/plugin-chart-table/src/TableChart.tsx:
##########
@@ -883,8 +884,12 @@ export default function TableChart<D extends DataRecord =
DataRecord>(
if (formatter.toTextColor) {
color = formatterResult.slice(0, -2);
+ } else if (formatter.toCellBar) {
+ if (showCellBars)
+ backgroundColorCellBar = formatterResult.slice(0, -2);
Review Comment:
You're right, I apologize for the oversight. The showCellBars check in the
formatter is indeed necessary to ensure cell bars aren't colored when globally
disabled. The current implementation correctly handles this requirement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
