bito-code-review[bot] commented on PR #35917:
URL: https://github.com/apache/superset/pull/35917#issuecomment-3470389784
<details open>
<summary><strong>Interaction Diagram by <a
href="https://bito.ai#sequence_diagram";>Bito</a></strong></summary>
```mermaid
sequenceDiagram
participant UI as UI Layer<br/>(DatasourceEditor)
participant DS as DatabaseSelector<br/>🔄 Updated | ●●○ Medium
participant TS as TableSelector<br/>🔄 Updated | ●●○ Medium
participant SFL as StyledFormLabel<br/>🟩 Added | ●●● High
participant RSR as renderSelectRow
participant Select as Select Component
participant Theme as Theme Provider
Note over SFL: New styled component<br/>extracted from Select header prop
UI->>DS: Render DatabaseSelector
DS->>SFL: Create styled label
SFL->>Theme: Apply theme styling
DS->>RSR: Render catalog/schema select
RSR->>Select: Render Select without header
Select-->>RSR: Return rendered select
UI->>TS: Render TableSelector
TS->>SFL: Create styled label
TS->>RSR: Render table select
RSR->>Select: Render Select without header
```
Critical path: UI Layer->DatabaseSelector->StyledFormLabel->Theme
Provider; TableSelector->StyledFormLabel->renderSelectRow->Select
Component
> **Note:** Labels are refactored from Select component's header prop to
a separate StyledFormLabel component rendered before renderSelectRow(). This
improves styling consistency and label positioning by centralizing label
rendering logic. Upstream components (DatasourceEditor, SqlEditorLeftBar) are
unaffected.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
