bito-code-review[bot] commented on PR #35918:
URL: https://github.com/apache/superset/pull/35918#issuecomment-3470397089
<details open>
<summary><strong>Interaction Diagram by <a
href="https://bito.ai#sequence_diagram";>Bito</a></strong></summary>
```mermaid
sequenceDiagram
participant TestRunner as Test Runner
participant TestFile as useThemeMenuItems.test.tsx<br/>🔄 Updated | ●●○ Medium
participant UserEvent as userEvent (Testing Library)<br/>●●○ Medium
participant ScreenAPI as screen (Testing Library)
participant Hook as useThemeMenuItems Hook
participant Component as TestComponent
Note over TestFile: All userEvent.hover() and<br/>userEvent.click() calls
now awaited
TestRunner->>TestFile: Execute test suite
TestFile->>Component: renderThemeMenu()
Component->>Hook: useThemeMenuItems(props)
Hook-->>Component: Return MenuItem
TestFile->>UserEvent: await userEvent.hover(menuitem)
UserEvent-->>TestFile: Hover action completed
TestFile->>ScreenAPI: findByRole/queryByText
ScreenAPI-->>TestFile: Return menu element
TestFile->>UserEvent: await userEvent.click(element)
UserEvent-->>TestFile: Click action completed
TestFile->>TestRunner: Assert results
```
Critical path: Test Runner -> useThemeMenuItems.test.tsx -> userEvent
(Testing Library) -> screen (Testing Library) -> Hook
> **Note:** All userEvent async operations (hover, click) now properly await
their promises. This ensures test stability by waiting for DOM updates before
assertions. No changes to the actual hook implementation; only test
synchronization improved.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
