sadpandajoe opened a new pull request, #35938:
URL: https://github.com/apache/superset/pull/35938
### SUMMARY
This PR completes the migration from Cypress to Playwright for
authentication tests by:
1. Removing the deprecated Cypress authentication test file
2. Making Playwright authentication tests required for CI (removes shadow
mode)
The Playwright auth tests have been running in parallel with Cypress tests
long enough to validate reliability with no false positives or negatives
observed. The Playwright implementation provides full test coverage with
enhanced error detection through the Page Object Model pattern and multiple
selector strategies.
**Changes:**
- Remove `continue-on-error: true` from
`.github/workflows/superset-playwright.yml`
- Delete `superset-frontend/cypress-base/cypress/e2e/auth/login.test.ts`
(49 lines)
- Playwright auth tests now block CI on failure
**Test Coverage Verified:**
- ✓ Failed login detection (with enhanced error message handling)
- ✓ Successful login flow with session cookie validation
- ✓ Both app_root configurations tested: `""` and `"/app/prefix"`
- ✓ Full parity with deleted Cypress tests
The Playwright workflow tests both app_root configurations and will now be
required for merge, ensuring authentication functionality is properly validated
in all deployment scenarios.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
