shivamsahu-tech commented on issue #35833:
URL: https://github.com/apache/superset/issues/35833#issuecomment-3476334885

   **Hey @rusackas,**
   This issue exists and is visible on my setup as well.  
   I've verified it in both **Chrome** and **Firefox** (Ubuntu 24.04), and you 
can check the images below for reference.
   
   ### Before (with issue)
   ![Before 
Chrome](https://drive.google.com/uc?export=view&id=1SJ8Php4oRh3_cEJTL1xGa3IGxzMUJPON)
   
   ### Cause
   In the file  
   
`superset-frontend/packages/superset-ui-core/src/components/Select/Select.tsx`  
   (at **line 739**), a prop `getPopupContainer` is passed indirectly to the 
**AntD Select** component.  
   However, this prop is later **overridden** by the same prop value coming 
from  
   `superset-frontend/src/features/databases/DatabaseModal/index.tsx` (at 
**line 1138**).
   ```tsx
   getPopupContainer={triggerNode =>
             triggerNode.parentElement || document.body
           }
   ```
   
   This setup forces the dropdown to render **inside its parent container** 
instead of the default `document.body`.  
   Since the parent container has a **limited height** and **overflow 
constraints**, it causes the dropdown to scroll within the parent component.
   
   ### Solution
   By default, **Ant Design** renders dropdowns inside `document.body`.  
   Removing the `getPopupContainer` prop from both locations allows AntD to 
handle this as intended, fixing the issue of **dual scrollbars** and **clipped 
dropdowns**.
   
   Additionally, since the `dropdownStyle` prop already defines proper 
`maxHeight` and `overflow` rules, removing this prop does **not** create any 
layout or overflow issues.
   
   ### After fix
   ![After 
Chrome](https://drive.google.com/uc?export=view&id=18U5_HJ0slhJ839KwOpL19YwuLYBPAovd)
   
   ***Please let me know if this is the right approach so i can create a PR.  
   I'm currently a student and eager to learn from your feedback.***


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to