EnxDev opened a new pull request, #35986: URL: https://github.com/apache/superset/pull/35986
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> This PR fixes an issue where clicking inside the Ace Editor’s autocomplete popover caused the main AntD popover to close unexpectedly. ### **SOLUTION** Moved the `.ace_autocomplete element` inside the parent container to prevent event propagation from closing the main popover. Hooked into Ace’s `afterExec event` to reposition the autocomplete when it appears. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> Navigate to charts 1) Create a new bar chart for a google sheet dataset or the examples dataset 2) Add Date as x-axis, sum(air-time) as metric and special-characters! as dimension 3) Try to add cancelation_reason as custom sql in Sort query by 4) The modal is closed when user click on the option listed ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
