Copilot commented on code in PR #35965:
URL: https://github.com/apache/superset/pull/35965#discussion_r2491658433
##########
superset-frontend/src/SqlLab/components/TemplateParamsEditor/index.tsx:
##########
@@ -35,6 +35,14 @@ const StyledConfigEditor = styled(ConfigEditor)`
}
`;
+const StyledParagraph = styled.p`
+ margin-top: 0;
+`;
+
+const Code = styled.code`
+ color: ${({ theme }) => theme.colorPrimary};
Review Comment:
Using only color to distinguish code elements may not provide sufficient
contrast or be accessible to users with color blindness. Consider adding
additional visual styling such as background color, font-weight, or font-family
to ensure code elements are distinguishable for all users.
```suggestion
color: ${({ theme }) => theme.colorPrimary};
background-color: ${({ theme }) => theme.colors.grayscale.light3};
font-family: 'SFMono-Regular', Consolas, 'Liberation Mono', Menlo,
Courier, monospace;
font-weight: 600;
padding: 2px 4px;
border-radius: 3px;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
