GitHub user dosubot[bot] added a comment to the discussion: Healthprobe says its health when database credentials are changed/renewed
<!-- Greeting --> Hi @thisispr! I'm [Dosu](https://go.dosu.dev/dosubot) and Iām helping the superset team. <!-- Answer --> Superset's current health/liveness probe (in master/latest-dev) only returns "OK" and does not check database connectivity, so it will report the app as healthy even if database credentials are changed or invalid. This is implemented in the health() function in `superset/views/health.py` and does not include any logic to verify database access or credential validity, which matches what you're seeing. Improving this would require extending the health check to verify connectivity to the metadata database before returning a healthy status. [See implementation reference](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset/views/health.py#L22-L29). <!-- Dosu Comment Footer --> *To reply, just mention [@dosu](https://go.dosu.dev/dosubot).* --- <sup>How did I do? [Good](https://app.dosu.dev/response-feedback/5b9a3866-a0a8-491a-b478-fa192ca6329f?feedback_type=great_response) | [Irrelevant](https://app.dosu.dev/response-feedback/5b9a3866-a0a8-491a-b478-fa192ca6329f?feedback_type=irrelevant_answer) | [Incorrect](https://app.dosu.dev/response-feedback/5b9a3866-a0a8-491a-b478-fa192ca6329f?feedback_type=incorrect_sources) | [Verbose](https://app.dosu.dev/response-feedback/5b9a3866-a0a8-491a-b478-fa192ca6329f?feedback_type=too_verbose) | [Hallucination](https://app.dosu.dev/response-feedback/5b9a3866-a0a8-491a-b478-fa192ca6329f?feedback_type=hallucination) | [Report š](https://app.dosu.dev/response-feedback/5b9a3866-a0a8-491a-b478-fa192ca6329f?feedback_type=bug_report) | [Other](https://app.dosu.dev/response-feedback/5b9a3866-a0a8-491a-b478-fa192ca6329f?feedback_type=other)</sup> [](https://app.dosu.dev/a28d3c7e-a9d3-459e-9fb6-3a6f9ff4f357/ask?utm_source=github)& nbsp;[](https://go.dosu.dev/discord-bot) [](https://twitter.com/intent/tweet?text=%40dosu_ai%20helped%20me%20solve%20this%20issue!&url=https%3A//github.com/apache/superset/issues/35988) GitHub link: https://github.com/apache/superset/discussions/36007#discussioncomment-14883849 ---- This is an automatically sent email for [email protected]. To unsubscribe, please send an email to: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
