gabotorresruiz opened a new pull request, #36010: URL: https://github.com/apache/superset/pull/36010
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> This PR addresses several UI polish issues across the navigation menu, CRUD table views, and chart editing interface: **Navigation Menu Improvements:** - Standardize spacing and paddings across the main Menu and RightMenu - Update dropdown icons from CaretDownOutlined to DownOutlined for consistency - Improve brand logo rendering - Add SQL Lab tab detection to properly highlight the "SQL" tab when viewing SQL Lab, Saved Queries or Query History **CRUD Table View Fixes:** - Fix inconsistent row heights in Dashboard/Chart/Dataset list views when FacePile avatars are present - Set consistent height on all table rows - Reduce vertical padding on cells containing `FacePile`'s **Chart Error Indicators:** - Change error validation icons from `InfoCircleOutlined` to `ExclamationCircleOutlined` - Update error icon color from `colorErrorText` to `colorError` for improved visibility in dark mode ### BEFORE/AFTER SCREENSHOTS <!--- Skip this if not applicable --> **Before:** - Wrong dropdown icons <img width="1055" height="56" alt="Screenshot 2025-11-05 at 17 55 19" src="https://github.com/user-attachments/assets/50856aa0-45b7-4e94-a461-3486ee4493cc"; /> - Wrong alignment <img width="332" height="119" alt="Screenshot 2025-11-05 at 17 58 19" src="https://github.com/user-attachments/assets/0c8b8bb9-65d2-4a5f-ae32-d6fd31b07e17"; /> - Different Dropdown Component for SQL tab <img width="222" height="197" alt="Screenshot 2025-11-05 at 17 55 40" src="https://github.com/user-attachments/assets/a735364d-9912-45b9-ab7f-cbb291aa0bc9"; /> - No border bottom when in SQL section <img width="1512" height="826" alt="Screenshot 2025-11-05 at 17 55 55" src="https://github.com/user-attachments/assets/031fcff1-49ab-4e80-abc9-83ebf6110a3c"; /> - Not Consistent height on table rows <img width="1484" height="302" alt="Screenshot 2025-11-05 at 17 57 05" src="https://github.com/user-attachments/assets/6b542191-003e-4df6-bc7f-3ae76425c036"; /> - Wrong error validation icons <img width="316" height="568" alt="Screenshot 2025-11-05 at 17 55 25" src="https://github.com/user-attachments/assets/d37b3f20-7ffd-4a13-98cb-001427a7c32f"; /> **After:** - New dropdown icons <img width="1069" height="56" alt="carets-after" src="https://github.com/user-attachments/assets/506cb535-e59f-43d4-a149-be03833ee40f"; /> - Correct alignment <img width="346" height="434" alt="Screenshot 2025-11-04 at 23 27 08" src="https://github.com/user-attachments/assets/4d7982f0-e20b-4aa2-a6ed-51ac5f7e00d5"; /> - Standardized Dropdown Component for SQL tab <img width="198" height="210" alt="Screenshot 2025-11-04 at 23 29 38" src="https://github.com/user-attachments/assets/2a098f1a-37e9-4283-8203-9c9e17388e1b"; /> - Border bottom when in SQL section <img width="1512" height="830" alt="Screenshot 2025-11-04 at 23 29 49" src="https://github.com/user-attachments/assets/6779d229-b8cc-4162-86f2-057d429e7df0"; /> - New logo standard styles to allow rendering any logo <img width="1512" height="63" alt="Screenshot 2025-11-04 at 23 46 18" src="https://github.com/user-attachments/assets/cb6c7cd9-588e-4791-854d-2bdf99402fea"; /> - Consistent height on table rows <img width="1487" height="195" alt="Screenshot 2025-11-05 at 13 00 40" src="https://github.com/user-attachments/assets/860bf948-513f-415c-b97b-e3555541846e"; /> - Fix error validation icons <img width="327" height="704" alt="Screenshot 2025-11-05 at 17 38 26" src="https://github.com/user-attachments/assets/3028d0f4-ae3f-4b80-a0fa-34e3aa2fff12"; /> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> **Navigation Menu:** 1. Hover over the `SQL` menu tab 2. Verify the tab border remains visible while the dropdown is open 3. Click into one of the options and see how the border remaings in the `SQL` menu tab **CRUD Table Views:** 1. Navigate to Dashboards, Charts, or Datasets list view 2. Observe rows with different numbers of owner avatars (FacePile) 3. Verify all rows have consistent height regardless of avatar count **Error Indicators:** 1. Navigate to chart editing (e.g., create/edit a line chart) 2. Remove all metrics from the Metrics field 3. Verify the error indicator shows an exclamation icon (!) not an info icon (i) 4. Check that the icon color is clearly visible in both light and dark modes ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
