aminghadersohi opened a new pull request, #36015: URL: https://github.com/apache/superset/pull/36015
### SUMMARY Reverts an unrelated flaky test fix that was accidentally included in PR #35163 (MCP service infrastructure). ### ISSUE The MCP service PR (#35163) included a `time.sleep(0.01)` workaround for a flaky test in `tests/integration_tests/charts/commands_tests.py`. As noted in the PR review, this change was unrelated to the MCP service and should have been in a separate PR. ### CHANGES **Reverted**: - Removed `import time` statement - Removed `time.sleep(0.01)` line before timestamp comparison **File**: `tests/integration_tests/charts/commands_tests.py` ### MOTIVATION This flaky test fix deserves its own investigation and proper solution: - The timestamp race condition needs proper analysis - Solutions like mocking time with `freezegun` may be more appropriate - The fix should be accompanied by explanation of the root cause ### NEXT STEPS - [ ] Create GitHub issue to track proper flaky test investigation - [ ] Investigate why `last_saved_at` timestamp comparison is flaky - [ ] Implement proper fix (mock time, use freezegun, or fix UpdateChartCommand) - [ ] Add test documentation explaining the timing sensitivity ### TESTING ✅ Reverted changes only ✅ No functional changes to test behavior ✅ Test may become flaky again (expected, needs proper fix) ### ADDITIONAL INFORMATION - [ ] Has associated issue: Will create after revert - [x] Required feature flags: None - [ ] Changes UI: No - [ ] Includes DB Migration: No - [ ] Introduces new feature or API: No - [x] Removes existing feature or API: Yes (removes workaround) **References**: - Original PR: #35163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
