sadpandajoe commented on code in PR #36028:
URL: https://github.com/apache/superset/pull/36028#discussion_r2505264471


##########
docs/docs/contributing/howtos.mdx:
##########
@@ -166,6 +166,56 @@ server:
 npm run dev-server
 ```
 
+#### Deploying your visualization plugin
+
+Once your plugin is complete, you will need to deploy it to your superset 
instance.
+
+This step assumes your are running your own docker image as described 
[here](https://superset.apache.org/docs/installation/docker-builds/#building-your-own-production-docker-image).
+Instructions may vary for other kinds of deployments.
+
+If you have your own superset docker image, your first line is most likely:
+`FROM apache/superset:latest` or something similar. You will need to compile
+your own `lean` image and replace this FROM line with your own image.
+
+1. publish your chart plugin to npm - it makes the build process simpler
+
+Note: if your chart is not published to npm, then in the docker build below, 
you will need
+to edit the default Dockerfile to copy your plugin source code to the 
appropriate
+location in the container build environment.
+
+2. Install your chart in the frontend with `npm i <your_chart_package>`

Review Comment:
   ```suggestion
   2. Install your chart in the frontend with `npm i <your_chart_package>`.
   ```



##########
docs/docs/contributing/howtos.mdx:
##########
@@ -166,6 +166,56 @@ server:
 npm run dev-server
 ```
 
+#### Deploying your visualization plugin
+
+Once your plugin is complete, you will need to deploy it to your superset 
instance.
+
+This step assumes your are running your own docker image as described 
[here](https://superset.apache.org/docs/installation/docker-builds/#building-your-own-production-docker-image).
+Instructions may vary for other kinds of deployments.
+
+If you have your own superset docker image, your first line is most likely:
+`FROM apache/superset:latest` or something similar. You will need to compile
+your own `lean` image and replace this FROM line with your own image.
+
+1. publish your chart plugin to npm - it makes the build process simpler
+
+Note: if your chart is not published to npm, then in the docker build below, 
you will need
+to edit the default Dockerfile to copy your plugin source code to the 
appropriate
+location in the container build environment.
+
+2. Install your chart in the frontend with `npm i <your_chart_package>`
+3. Start with a base superset release
+
+```bash
+git checkout tags/X.0.0
+```
+
+4. Install your chart with the instructions you followed during development.
+5. navigate to the root of your superset directory.

Review Comment:
   ```suggestion
   5. Navigate to the root of your superset directory.
   ```



##########
docs/docs/contributing/howtos.mdx:
##########
@@ -166,6 +166,56 @@ server:
 npm run dev-server
 ```
 
+#### Deploying your visualization plugin
+
+Once your plugin is complete, you will need to deploy it to your superset 
instance.
+
+This step assumes your are running your own docker image as described 
[here](https://superset.apache.org/docs/installation/docker-builds/#building-your-own-production-docker-image).
+Instructions may vary for other kinds of deployments.
+
+If you have your own superset docker image, your first line is most likely:
+`FROM apache/superset:latest` or something similar. You will need to compile
+your own `lean` image and replace this FROM line with your own image.
+
+1. publish your chart plugin to npm - it makes the build process simpler
+
+Note: if your chart is not published to npm, then in the docker build below, 
you will need
+to edit the default Dockerfile to copy your plugin source code to the 
appropriate
+location in the container build environment.
+
+2. Install your chart in the frontend with `npm i <your_chart_package>`
+3. Start with a base superset release

Review Comment:
   ```suggestion
   3. Start with a base superset release.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to