aminghadersohi commented on code in PR #36035:
URL: https://github.com/apache/superset/pull/36035#discussion_r2505975763
##########
superset/mcp_service/chart/schemas.py:
##########
@@ -79,8 +80,8 @@ class ChartLike(Protocol):
class ChartInfo(BaseModel):
"""Full chart model with all possible attributes."""
- id: int = Field(..., description="Chart ID")
- slice_name: str = Field(..., description="Chart name")
+ id: int | None = Field(None, description="Chart ID")
+ slice_name: str | None = Field(None, description="Chart name")
Review Comment:
this change is intentional. nobody is using this service right now.
##########
superset/mcp_service/dashboard/schemas.py:
##########
@@ -252,8 +259,8 @@ class GetDashboardInfoRequest(MetadataCacheControl):
class DashboardInfo(BaseModel):
- id: int = Field(..., description="Dashboard ID")
- dashboard_title: str = Field(..., description="Dashboard title")
+ id: int | None = Field(None, description="Dashboard ID")
+ dashboard_title: str | None = Field(None, description="Dashboard title")
Review Comment:
no. this change is intentional
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
