kgabryje commented on code in PR #36051:
URL: https://github.com/apache/superset/pull/36051#discussion_r2510046598
##########
superset/utils/screenshot_utils.py:
##########
@@ -190,9 +180,6 @@ def take_tiled_screenshot(
logger.info("Combining screenshot tiles...")
combined_screenshot = combine_screenshot_tiles(screenshot_tiles)
- # Reset window scroll position
- page.evaluate("window.scrollTo(0, 0)")
Review Comment:
Yes, it wasn't really necessary. `scrollTo` takes absolute coordinates, not
relative, so we don't need to scroll back to the top after each loop
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
