msyavuz commented on code in PR #36045:
URL: https://github.com/apache/superset/pull/36045#discussion_r2511024922
##########
superset-frontend/src/dashboard/components/PropertiesModal/index.tsx:
##########
@@ -586,20 +586,26 @@ const PropertiesModal = ({
sections: modalSections,
});
- // Validate basic section when title changes
+ // Validate basic section when title changes or data loads
useEffect(() => {
- validateSection('basic');
- }, [dashboardTitle, validateSection]);
+ if (!isLoading && dashboardInfo) {
Review Comment:
This check seems like a good candidate to extract out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
