richardfogaca commented on code in PR #36011:
URL: https://github.com/apache/superset/pull/36011#discussion_r2512307213
##########
superset-frontend/src/dashboard/components/gridComponents/Chart/Chart.jsx:
##########
@@ -612,18 +612,18 @@ export default memo(Chart, (prevProps, nextProps) => {
return false;
}
return (
- !nextProps.isComponentVisible ||
- (prevProps.isInView === nextProps.isInView &&
- prevProps.componentId === nextProps.componentId &&
- prevProps.id === nextProps.id &&
- prevProps.dashboardId === nextProps.dashboardId &&
- prevProps.extraControls === nextProps.extraControls &&
- prevProps.handleToggleFullSize === nextProps.handleToggleFullSize &&
- prevProps.isFullSize === nextProps.isFullSize &&
- prevProps.setControlValue === nextProps.setControlValue &&
- prevProps.sliceName === nextProps.sliceName &&
- prevProps.updateSliceName === nextProps.updateSliceName &&
- prevProps.width === nextProps.width &&
- prevProps.height === nextProps.height)
+ prevProps.isComponentVisible === nextProps.isComponentVisible &&
Review Comment:
Hi @msyavuz this change was a test for a blind fix that didn't work
(couldn't reproduce the issue), so I'll need to figure out another solution.
But thanks for the review anyway
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
