korbit-ai[bot] commented on code in PR #36063: URL: https://github.com/apache/superset/pull/36063#discussion_r2512396444
########## superset/mcp_service/system/schemas.py: ########## @@ -28,6 +28,20 @@ from pydantic import BaseModel, ConfigDict, Field +class GetHealthCheckRequest(BaseModel): + """ + Request schema for health_check tool. + + Currently has no parameters but provides consistent API for future extensibility. + This prevents validation errors when MCP clients call the tool with an empty object. + """ + + model_config = ConfigDict( + extra="forbid", + str_strip_whitespace=True, + ) Review Comment: ### Unnecessary str_strip_whitespace configuration <sub></sub> <details> <summary>Tell me more</summary> ###### What is the issue? The GetHealthCheckRequest class has no fields but uses str_strip_whitespace=True configuration, which is unnecessary and potentially misleading since there are no string fields to strip whitespace from. ###### Why this matters This configuration option serves no purpose in a model with no fields and could confuse developers about the model's intended behavior. It may also cause unnecessary processing overhead during validation. ###### Suggested change ∙ *Feature Preview* Remove the str_strip_whitespace=True configuration since there are no string fields in this model: ```python model_config = ConfigDict( extra="forbid", ) ``` ###### Provide feedback to improve future suggestions [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/543dff10-c34f-486b-8498-517968d6dfd3/upvote) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/543dff10-c34f-486b-8498-517968d6dfd3?what_not_true=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/543dff10-c34f-486b-8498-517968d6dfd3?what_out_of_scope=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/543dff10-c34f-486b-8498-517968d6dfd3?what_not_in_standard=true) [](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/543dff10-c34f-486b-8498-517968d6dfd3) </details> <sub> 💬 Looking for more details? Reply to this comment to chat with Korbit. </sub> <!--- korbi internal id:509a636b-679e-47e2-a5cb-aa377c07db86 --> [](509a636b-679e-47e2-a5cb-aa377c07db86) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
