msyavuz commented on code in PR #35264:
URL: https://github.com/apache/superset/pull/35264#discussion_r2517089858


##########
superset-frontend/src/components/Datasource/components/DatasourceEditor/DatasourceEditor.jsx:
##########
@@ -837,6 +838,11 @@ class DatasourceEditor extends PureComponent {
           col => !col.expression, // remove calculated columns
         ),
       });
+
+      // Clear the dataset cache to ensure fresh data when fetching columns 
for filters
+      // This ensures that newly synced columns are immediately available in 
filter creation

Review Comment:
   Hey, this is to prevent stale data by clearing the cache when syncing 
metadata. Isn't this the expected behaviour? I think it would be confusing for 
users to have that option when it should be done by default



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to