igor-tech opened a new pull request, #36081:
URL: https://github.com/apache/superset/pull/36081

   <!---
   Please write the PR title following the conventions at 
https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   Fixes missing bottom border on the last row label when grouping is expanded 
in Pivot Table visualization. 
   
   Previously, when multiple groups were present and the last group was 
expanded, the bottom border was not rendered, creating a visual inconsistency. 
This PR adds logic to detect the last row and applies the `pvtRowLabelLast` CSS 
class, which adds the missing border-bottom style.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   **Before:**
   <img width="995" height="443" alt="image" 
src="https://github.com/user-attachments/assets/f0630801-5053-4396-b1b3-460fbf5205c2";
 />
   
   **After:**
   <img width="767" height="280" alt="image" 
src="https://github.com/user-attachments/assets/88728a60-65a0-4d1b-8ec1-574bd8209731";
 />
   
   ### TESTING INSTRUCTIONS
   1. Create a Pivot Table chart with multiple row groupings
   2. Expand all groups to show nested data
   3. Verify that the bottom border is now visible on the last row label
   4. Check that the border appears correctly when:
      - Last group is collapsed
      - Last group is expanded
      - Column totals are enabled/disabled
   
   ### ADDITIONAL INFORMATION
   - [x] Has associated issue: Fixes #36031
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in SIP-59)
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to