msyavuz commented on PR #35265:
URL: https://github.com/apache/superset/pull/35265#issuecomment-3522019061
Thanks for the review @geido! I've addressed your feedback:
1. **Added comprehensive tests**: Created test cases covering the tab
refresh behavior including:
- Refreshing charts when tab becomes visible after dashboard refresh
- Not refreshing when tab was already visited after refresh
- Handling empty tabs and nested chart components
- Ensuring refresh only happens when tab is visible
2. **Improved chart mounting guarantee**: Now using `requestAnimationFrame`
before the timeout to ensure DOM is ready, which better handles lazy-loaded
dashboards.
3. **Optimized performance**: Changed to select only the specific tab's
activation time instead of the entire object, reducing unnecessary re-renders.
The combination of `requestAnimationFrame` + timeout provides better
guarantees that charts are mounted before refresh attempts, addressing the
lazy-loading concern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
