Copilot commented on code in PR #36059:
URL: https://github.com/apache/superset/pull/36059#discussion_r2519366789
##########
superset-frontend/packages/superset-ui-core/src/components/Select/Select.tsx:
##########
@@ -734,9 +734,6 @@ const Select = forwardRef(
popupRender={popupRender}
filterOption={handleFilterOption}
filterSort={sortComparatorWithSearch}
Review Comment:
The `getPopupContainer` prop is still defined in the TypeScript interface
`AntdExposedProps` (line 72 in types.ts), but it's no longer being used in the
implementation. This creates a type/implementation mismatch where users can
pass the prop without TypeScript errors, but it will be silently ignored.
Consider removing `getPopupContainer` from the `AntdExposedProps` type
definition to match the implementation and prevent confusion.
##########
superset-frontend/packages/superset-ui-core/src/components/Select/Select.tsx:
##########
@@ -734,9 +734,6 @@ const Select = forwardRef(
popupRender={popupRender}
filterOption={handleFilterOption}
filterSort={sortComparatorWithSearch}
Review Comment:
The `getPopupContainer` prop was removed here to fix the dual scrollbar
issue, but it's still present in `AsyncSelect.tsx` (lines 611-613). For
consistency and to ensure the same issue doesn't occur with async select
dropdowns, consider removing it from AsyncSelect as well. This would ensure
both Select components have consistent behavior and avoid potential dual
scrollbar issues in async select dropdowns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
