dosubot[bot] commented on issue #34784:
URL: https://github.com/apache/superset/issues/34784#issuecomment-3530329462

   <!-- Answer -->
   Based on the latest code and recent changes, the calculated column SQL 
generation bug with ClickHouse and OPTIMIZE_SQL=True from 6.0.0rc1 does not 
appear to persist. The current SQL generation logic for calculated columns is 
handled generically and does not depend on the OPTIMIZE_SQL flag, so calculated 
columns should now generate correct SQL for ClickHouse regardless of that 
setting. No recent code or pull requests specifically address this bug, but the 
logic has stabilized and the issue should be resolved in the latest version.  
   [Reference: SQL generation logic in 
superset/connectors/sqla/models.py](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset/connectors/sqla/models.py)
  
   [Reference: ClickHouse engine 
spec](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset/db_engine_specs/clickhouse.py)
   
   
   <!-- Dosu Comment Footer -->
   *To reply, just mention [@dosu](https://go.dosu.dev/dosubot).*
   
   ---
   <sup>How did I do? 
[Good](https://app.dosu.dev/response-feedback/cbacb2c7-145b-47fd-b7bd-2ea63994598e?feedback_type=great_response)
 | 
[Irrelevant](https://app.dosu.dev/response-feedback/cbacb2c7-145b-47fd-b7bd-2ea63994598e?feedback_type=irrelevant_answer)
 | 
[Incorrect](https://app.dosu.dev/response-feedback/cbacb2c7-145b-47fd-b7bd-2ea63994598e?feedback_type=incorrect_sources)
 | 
[Verbose](https://app.dosu.dev/response-feedback/cbacb2c7-145b-47fd-b7bd-2ea63994598e?feedback_type=too_verbose)
 | 
[Hallucination](https://app.dosu.dev/response-feedback/cbacb2c7-145b-47fd-b7bd-2ea63994598e?feedback_type=hallucination)
 | [Report 
🐛](https://app.dosu.dev/response-feedback/cbacb2c7-145b-47fd-b7bd-2ea63994598e?feedback_type=bug_report)
 | 
[Other](https://app.dosu.dev/response-feedback/cbacb2c7-145b-47fd-b7bd-2ea63994598e?feedback_type=other)</sup>&nbsp;&nbsp;[![Chat
 with 
Dosu](https://dosu.dev/dosu-chat-badge.svg)](https://app.dosu.dev/a28d3c7e-a9d3-459e-9fb6-3a6f9ff4f357/ask?utm_source=githu
 b)&nbsp;[![Join 
Discord](https://img.shields.io/badge/join-5865F2?logo=discord&logoColor=white&label=)](https://go.dosu.dev/discord-bot)&nbsp;[![Share
 on 
X](https://img.shields.io/badge/X-share-black)](https://twitter.com/intent/tweet?text=%40dosu_ai%20helped%20me%20solve%20this%20issue!&url=https%3A//github.com/apache/superset/issues/34784)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to