rusackas commented on PR #35777:
URL: https://github.com/apache/superset/pull/35777#issuecomment-3534384098
Thanks for taking care of so many of the review comments.
Added a comment elsewhere, but in re-reviewing this, I'm noticing that a lot
of `JSON.parse` is being used here for direct localstorage access. You can slim
down the code (and prevent things found by the bot reviews) by using
`localStorageHelpers` as mentioned in your PR description.
As you'll spot in other areas of the codebase, you can import the bits you
need like
```
import {
LocalStorageKeys,
getItem,
setItem,
} from 'src/utils/localStorageHelpers';
```
and then use `setItem` and `getItem` to not worry about the JSON bits, and
provide defaults as needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
