gabotorresruiz opened a new pull request, #36125: URL: https://github.com/apache/superset/pull/36125
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> This PR adds a new `setThemeMode()` method to the embedded SDK that allows host applications to dynamically control the theme mode (default/dark/system) of embedded dashboards. ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> 1. Set up an embedded dashboard using the SDK 2. Configure a theme with both `theme_default` and `theme_dark`: ```typescript const dashboard = await embedDashboard({ /* config */ }); dashboard.setThemeConfig({ theme_default: { token: { colorPrimary: '#458588' } }, theme_dark: { token: { colorPrimary: '#458588', colorBgBase: '#282828' }, algorithm: 'dark' } }); ``` 3. Call `dashboard.setThemeMode('dark')` - verify dashboard switches to dark theme 4. Call `dashboard.setThemeMode('default')` - verify dashboard switches to default theme 5. Test theme locking: Configure a dashboard with only theme_default, verify `setThemeMode('dark')` is silently ignored (no errors, dashboard stays in default mode) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
