alexandrusoare commented on code in PR #36122:
URL: https://github.com/apache/superset/pull/36122#discussion_r2533365827
##########
superset-frontend/src/explore/controlUtils/standardizedFormData.ts:
##########
@@ -81,6 +81,8 @@ export const publicControls = [
// advanced analytics - resample
'resample_rule', // via sections.advancedAnalytics
'resample_method', // via sections.advancedAnalytics
+ // dashboard context
+ 'dashboardId', // preserve dashboard context when changing viz type
];
Review Comment:
Does this save all dashboard ids where the chart is present or just the
dashboard you accessed the explore from?
##########
superset-frontend/src/explore/controlUtils/standardizedFormData.ts:
##########
@@ -216,6 +218,7 @@ export class StandardizedFormData {
});
const targetFormData = {
...getFormDataFromControls(targetControlsState),
+ ...publicFormData,
standardizedFormData: this.serialize(),
Review Comment:
Why do we need to send the whole object of publicFormData and not just the
`dashboardId`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
