Rattlyy commented on issue #36132: URL: https://github.com/apache/superset/issues/36132#issuecomment-3541203529
5.0.0 is broken because #31194 instead of just setting display:none entirely removes anchor links, which breaks this behaviour. Other versions are also broken because the AnchorLink component instead of always scrolling checks if the link's anchor (https://superset/example**#anchor**) is the same as the anchor param in the json returned by the permalink request. The anchor link param is appended by Superset when redirecting with the normal permalink url, if you pass the manual permalink_key url query param it's broken also in non-embedded tabs. So we have two bugs here. Both in normal Superset dashboards (when using only permalink_key url query param) and in Embedded (in 5.0.0 anchorlinks are removed entirely from the final page, check #31194) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
