sadpandajoe commented on code in PR #36108:
URL: https://github.com/apache/superset/pull/36108#discussion_r2535114178
##########
superset/commands/database/uploaders/csv_reader.py:
##########
@@ -414,7 +414,16 @@ def _read_csv( # noqa: C901
break
if chunks:
- result = pd.concat(chunks, ignore_index=False)
+ try:
+ result = pd.concat(chunks, ignore_index=False)
+ except Exception as ex:
+ logger.warning(
+ "Error concatenating CSV chunks: %s. "
+ "This may be due to inconsistent date parsing
across chunks.",
+ str(ex),
+ )
+ raise
+
Review Comment:
If we have repro steps, can we not just run this locally to get the logs for
root cause or are we saying this is intermittent? Also if we are merging this,
can we just have a quick test to make sure exception is thrown and is still
raised afterwards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
