bito-code-review[bot] commented on code in PR #36144:
URL: https://github.com/apache/superset/pull/36144#discussion_r2535603661
##########
docs/docs/configuration/theming.mdx:
##########
@@ -215,38 +214,45 @@ Target specific chart types using
`echartsOptionsOverridesByChartType`:
THEME_DEFAULT = {
"token": {
"colorPrimary": "#2893B3",
- # ... other tokens
- },
- "echartsOptionsOverridesByChartType": {
- "echarts_pie": {
+ "echartsOptionsOverridesByChartType": {
+ "pie": {
+ "tooltip": {
+ "backgroundColor": "rgba(0, 0, 0, 0.8)",
+ "borderColor": "#ccc",
+ "textStyle": {
+ "color": "#fff"
+ }
+ },
"legend": {
- "orient": "vertical",
- "right": 10,
- "top": "center"
+ "orient": "vertical",
+ "right": 10,
+ "top": "center"
}
- },
- "echarts_timeseries": {
+ },
+ "echarts_timeseries": {
"xAxis": {
- "axisLabel": {
- "rotate": 45,
- "fontSize": 12
- }
+ "axisLabel": {
+ "rotate": 45,
+ "fontSize": 12
+ }
},
- "dataZoom": [{
+ "dataZoom": [
+ {
"type": "slider",
- "show": True,
+ "show": "True",
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Wrong data type for dataZoom show</b></div>
<div id="fix">
The dataZoom 'show' option in the echarts_timeseries configuration example
is incorrectly set to the string "True" instead of the boolean True. This will
prevent the dataZoom slider from displaying in ECharts visualizations, as the
library expects a boolean value. The configuration is passed to ECharts, which
requires strict data types for proper rendering.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
````suggestion
"show": True,
````
</div>
</details>
</div>
<small><i>Code Review Run <a
href=https://github.com/apache/superset/pull/36144#issuecomment-3543944759>#a0cc9a</a></i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
