sadpandajoe opened a new pull request, #36175: URL: https://github.com/apache/superset/pull/36175
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY This PR adds comprehensive unit test coverage for the dataset API hooks used in the filter configuration flow, plus fixes two critical bugs discovered during testing. **New Test Coverage (35 tests)** src/hooks/apiResources/datasets.test.ts (21 tests) - getDatasetId utility function - ID extraction from string/numeric formats - createVerboseMap utility function - verbose name mapping from columns/metrics - useDatasetDrillInfo hook - REST API path, caching behavior, error handling - Extension path coverage - drill-by extension integration, error handling, malformed payloads - Edge cases - NaN IDs, empty strings, malformed datasource IDs src/features/datasets/hooks/useDatasetLists.test.ts (14 tests) - Pagination - single page, multi-page fetching - Error handling - API errors, network timeouts, persistent failures - Guard conditions - schema null/undefined, database undefined - Schema encoding - special characters in schema names **Bug Fixes** 1. Pagination infinite loop (useDatasetLists.ts:68) - Problem: Error handler in pagination loop didn't break, causing infinite retries on persistent API errors - Fix: Added break statement in catch block - Risk: CRITICAL - could cause browser hangs/crashes 2. Missing database guard (useDatasetLists.ts:82) - Problem: API calls fired with database: undefined when db not selected - Fix: Added db?.id !== undefined check to guard condition - Risk: MEDIUM - API spam with malformed filters ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
