rusackas commented on PR #36228: URL: https://github.com/apache/superset/pull/36228#issuecomment-3572089849
A couple of questions here: 1) Since both of these plugins are using identical utils here, can we adhere to the DRY principle and add such utils in superset-ui/core? 2) It seems that we're _checking_ if the formatter is valid (trimming and all that), but we're not actually doing the trimming when applying the filter... so I'm not sure if this actually _fixes_ the underlying issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
