bito-code-review[bot] commented on code in PR #36265:
URL: https://github.com/apache/superset/pull/36265#discussion_r2559714001
##########
docker/pythonpath_dev/superset_config.py:
##########
@@ -51,7 +51,16 @@ def get_env_variable(var_name: str, default: Optional[str] =
None) -> str:
DATABASE_HOST = get_env_variable("DATABASE_HOST")
DATABASE_PORT = get_env_variable("DATABASE_PORT")
DATABASE_DB = get_env_variable("DATABASE_DB")
-
+SESSION_COOKIE_SAMESITE = None
+ENABLE_PROXY_FIX = True
+PUBLIC_ROLE_LIKE_GAMMA = True
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Use of removed deprecated config key</b></div>
<div id="fix">
The configuration uses the deprecated PUBLIC_ROLE_LIKE_GAMMA key, which has
been removed in recent Superset versions as indicated in the UPDATING.md and
CHANGELOG.md. This will not enable public role access like Gamma as intended,
potentially breaking access for unauthenticated users in production. Replace it
with PUBLIC_ROLE_LIKE = "Gamma" to achieve the same functionality, as the old
key is no longer supported and the code in superset/security/manager.py now
checks for PUBLIC_ROLE_LIKE instead.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
````suggestion
PUBLIC_ROLE_LIKE = "Gamma"
````
</div>
</details>
</div>
<small><i>Code Review Run <a
href=https://github.com/apache/superset/pull/36265#issuecomment-3575244159>#0db9cf</a></i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
