CoffeeWriter commented on PR #36083: URL: https://github.com/apache/superset/pull/36083#issuecomment-3576241960
@rusackas @SBIN2010 I believe the trailing whitespace issue from Copilot was resolved by the pre-commit fix. Also, regarding Copilot's suggestion about handleFilteredDataChange, I think it's fine as it is. The totals query strips out all non-metric columns, so the backend only returns metric-related totals. I also tested it in the dev environment, and it works correctly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
