betodealmeida opened a new pull request, #36274: URL: https://github.com/apache/superset/pull/36274
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> Contribution charts were missing cache hits on `force_cached=True` because the totals query used in post-processing kept its original `row_limit` (e.g., 1000) when building cache keys on fetch, while the cached entry was produced with `row_limit=None` during async computation. This mismatch could trigger unnecessary async jobs and redundant totals recalculations, undermining performance and cache consistency for contribution workloads. This change introduces a normalization helper that always sets the totals query `row_limit` to `None` before cache-key generation, even for force-cached reads, and reuses that helper inside `ensure_totals_available` to avoid duplicated logic. The force-cached path now aligns cache keys without executing totals, and a unit test verifies the totals query is normalized without running a new totals query, preserving expected cache hits. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
