aminghadersohi commented on code in PR #36245:
URL: https://github.com/apache/superset/pull/36245#discussion_r2566727752
##########
superset/connectors/sqla/models.py:
##########
@@ -212,6 +212,78 @@ def name(self) -> str:
extra_import_fields = ["is_managed_externally", "external_url"]
+ @property
+ def cache_timeout(self) -> int | None:
+ """
+ Get the cache timeout for this datasource.
+
+ Implements the Explorable protocol by handling the fallback chain:
+ 1. Datasource-specific timeout (if set)
+ 2. Database default timeout (if no datasource timeout)
+ 3. None (use system default)
+
+ This allows each datasource to override caching, while falling back
+ to database-level defaults when appropriate.
+ """
+ if self._cache_timeout is not None:
+ return self._cache_timeout
+
+ # database should always be set, but that's not true for v0 import
+ if self.database:
+ return self.database.cache_timeout
+
+ return None
+
+ @cache_timeout.setter
+ def cache_timeout(self, value: int | None) -> None:
+ """Set the datasource-specific cache timeout."""
+ self._cache_timeout = value
+
+ def has_drill_by_columns(self, column_names: list[str]) -> bool:
+ """
+ Check if the specified columns support drill-by operations.
+
+ For SQL datasources, drill-by is supported on columns that are marked
+ as groupable in the metadata. This allows users to navigate from
+ aggregated views to detailed data by grouping on these dimensions.
+
+ :param column_names: List of column names to check
+ :return: True if all columns support drill-by, False otherwise
+ """
+ if not column_names:
+ return False
+
+ # Get all groupable column names for this datasource
+ drillable_columns = {
+ row[0]
+ for row in db.session.query(TableColumn.column_name)
+ .filter(TableColumn.table_id == self.id)
+ .filter(TableColumn.groupby)
+ .all()
+ }
+
+ # Check if all requested columns are drillable
+ return set(column_names).issubset(drillable_columns)
+
+ def get_time_grains(self) -> list[dict[str, Any]]:
Review Comment:
is TypedDict useful here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
