rusackas commented on PR #36275: URL: https://github.com/apache/superset/pull/36275#issuecomment-3590352121
Yep, agree with @msyavuz but this is a great step in the right direction. Do you want to continue working on these @OrhanBC (and team)? From here, we can probably pick one control at a time, and give it this treatment _across plugins_. Then we can make sure that we're either putting the React component in the plugin's codebase (where it's unique to the pligin) or in `@superset-ui`'s shared controls if it's one that is (or could/should be) used across multiple plugins. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
